Open
Conversation
Owner
|
Hmm... I've been pondering this on and off for a couple hours since you submitted the PR I think the error message might just be a typo - let me explain my reasoning Currently the tool doesn't allow Your change would allow that but disallow I can definitely come up with a reason for the first not to work. - it doesn't make clear if the host changed. The second one I can reasonably safely assume the host did not change - so we definitely don't want to block that. I also wonder if a FROM specifying a I'm half wondering if a new setting, some sort of host-check strictness option is in order here… Let me ponder some more and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
first of all - thank you very much for your work!
I currently tried to use it in one of my projects to automatically generate .htaccess based redirects out of the Database.
While implementing it, i noticed the from host <> to host validation is kind of interchanged.
Br,
Daniel :)